[all-commits] [llvm/llvm-project] 7ebfc8: [HLSL][NFC] Refactoring HLSLExternalSemaSource

[Helena Kotas via All-commits]

  Branch: refs/heads/users/hekota/pr-131032-ext-sema-source-refactor
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ebfc826ca27c71ef80f4a1b38b2d3a2e155b777
      https://github.com/llvm/llvm-project/commit/7ebfc826ca27c71ef80f4a1b38b2d3a2e155b777
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M clang/include/clang/Sema/HLSLExternalSemaSource.h
    M clang/lib/Sema/CMakeLists.txt
    A clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
    A clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h
    M clang/lib/Sema/HLSLExternalSemaSource.cpp

  Log Message:
  -----------
  [HLSL][NFC] Refactoring HLSLExternalSemaSource

Moving builder classes into separate files `HLSLBuiltinTypeDeclBuilder.cpp`/`.h` and changing a some `HLSLExternalSemaSource` methods to private.

This is a prep work before we start adding more builtin types and methods, like textures or resource constructors. For example constructors could make use of the `BuiltinTypeMethodBuilder`, but this helper class was defined in `HLSLExternalSemaSource.cpp` after the method that creates a constructor. Rather than reshuffling the code one big source file I am moving the builders into a separate cpp & header file and placing the helper classes declarations up top.

Currently the new header only exposes `BuiltinTypeDeclBuilder` to `HLSLExternalSemaSource`. In the future but we might decide to expose more helper classes as needed.


  Commit: 443eb3def1025b2a2aac7b74c32ef28bbc9a15a2
      https://github.com/llvm/llvm-project/commit/443eb3def1025b2a2aac7b74c32ef28bbc9a15a2
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h

  Log Message:
  -----------
  Remove BuiltinTypeDeclBuilder::startDefinition - it is not used


Compare: https://github.com/llvm/llvm-project/compare/7ebfc826ca27%5E...443eb3def102

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications