[all-commits] [llvm/llvm-project] 9de8c6: [flang][OpenMP] Translate OpenMP scopes when compi...

[Kareem Ergawy via All-commits]

  Branch: refs/heads/users/ergawy/try_to_fix_nested_target_conversion_2
  Home:   https://github.com/llvm/llvm-project
  Commit: 9de8c664bad3a851e3b9644711b24c6449db9e49
      https://github.com/llvm/llvm-project/commit/9de8c664bad3a851e3b9644711b24c6449db9e49
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Target/LLVMIR/openmp-target-nesting-in-host-ops.mlir

  Log Message:
  -----------
  [flang][OpenMP] Translate OpenMP scopes when compiling for target device

If a `target` directive is nested in a host OpenMP directive (e.g.
parallel, task, or a worksharing loop), flang currently crashes if the
target directive-related MLIR ops (e.g. `omp.map.bounds` and
`omp.map.info` depends on SSA values defined inside the parent host
OpenMP directives/ops.

This PR tries to solve this problem by treating these parent OpenMP ops
as "SSA scopes". Whenever we are translating for the device, instead of
completely translating host ops, we just tranlate their MLIR ops as pure
SSA values.


  Commit: 1d8b2bf5eee51c5f68ba2e0a3ab2e4662e1bb388
      https://github.com/llvm/llvm-project/commit/1d8b2bf5eee51c5f68ba2e0a3ab2e4662e1bb388
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  handle some review comments


  Commit: 57679e15db18bd18585289058681e33db98ddba6
      https://github.com/llvm/llvm-project/commit/57679e15db18bd18585289058681e33db98ddba6
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  update docs


  Commit: 59d8dfc9eabae6b16cb28b1a05b9be087fec40b5
      https://github.com/llvm/llvm-project/commit/59d8dfc9eabae6b16cb28b1a05b9be087fec40b5
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/openmp-target-nesting-in-host-ops.mlir

  Log Message:
  -----------
  handle review comments


Compare: https://github.com/llvm/llvm-project/compare/5ef645d0e13a...59d8dfc9eaba

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications