[all-commits] [llvm/llvm-project] 15e335: [flang] also set llvm ABI argument attributes on d...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 15e335f04fba3d16e195c055952649f8852e3b35
      https://github.com/llvm/llvm-project/commit/15e335f04fba3d16e195c055952649f8852e3b35
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/TargetRewrite.cpp
    M flang/test/Fir/CUDA/cuda-target-rewrite.mlir
    M flang/test/Fir/struct-passing-return-loongarch64-bystack.fir
    M flang/test/Fir/struct-passing-x86-64-byval.fir
    M flang/test/Fir/struct-passing-x86-64-one-field-inreg.fir
    M flang/test/Fir/struct-passing-x86-64-several-fields-inreg.fir
    M flang/test/Fir/struct-return-aarch64.fir
    M flang/test/Fir/struct-return-loongarch64-byreg.fir
    M flang/test/Fir/struct-return-powerpc64-aix.fir
    M flang/test/Fir/struct-return-ppc64le.fir
    M flang/test/Fir/struct-return-x86-64.fir
    M flang/test/Fir/target-rewrite-complex-10-x86.fir
    M flang/test/Fir/target-rewrite-complex.fir
    M flang/test/Fir/target-rewrite-complex16.fir
    M flang/test/Fir/target-rewrite-indirect-calls.fir
    M flang/test/Fir/target-rewrite-integer-loongarch64.fir
    M flang/test/Fir/target.fir

  Log Message:
  -----------
  [flang] also set llvm ABI argument attributes on direct calls (#130736)

So far, flang was not setting argument attributes on direct calls
assuming that putting them on the function operation was enough.

It was clarified in
https://github.com/llvm/llvm-project/commit/38565da5259729898c2a552d54b72f3314241734
that they must be set on both call and functions, even for direct calls.

Crashes have been observed because of the lack of the attribute when
compiling `abs(x)` at `O2` and above on X86-64 for complex(16).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications