[all-commits] [llvm/llvm-project] 606e9f: [WindowsDriver] Always consider `WinSdkVersion` (#...

[Fabrice de Gans via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 606e9fa444559923a9e03cbdffc1abd9e2582d60
      https://github.com/llvm/llvm-project/commit/606e9fa444559923a9e03cbdffc1abd9e2582d60
  Author: Fabrice de Gans <Steelskin at users.noreply.github.com>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M llvm/lib/WindowsDriver/MSVCPaths.cpp

  Log Message:
  -----------
  [WindowsDriver] Always consider `WinSdkVersion` (#130377)

Currently, the `-Xmicrosoft-windows-sdk-version` is only used if
`-Xmicrosoft-windows-sdk-root` is also provided. This is a surprising
behavior since the argument should still be taking effect if LLVM uses
the Windows SDK root from the registry.

Tested locally in a simple Hello World program including `Windows.h` and
compiled with `-Xmicrosoft-windows-sdk-version 10.0.18362.0` on a system
where the SDK 10.0.22621.0 is also installed and verified that the
correct header was included.

Co-authored-by: Saleem Abdulrasool <compnerd at compnerd.org>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications