[all-commits] [llvm/llvm-project] f3e559: [mlir][ODS] Switch declarative rewrite rules to pr...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3e55944a9468842746467494dd89724a66fc533
      https://github.com/llvm/llvm-project/commit/f3e55944a9468842746467494dd89724a66fc533
  Author: Krzysztof Drewniak <krzysdrewniak at gmail.com>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    A mlir/test/mlir-tblgen/rewriter-attributes-properties.td
    M mlir/tools/mlir-tblgen/RewriterGen.cpp

  Log Message:
  -----------
  [mlir][ODS] Switch declarative rewrite rules to properties structs (#124876)

Now that we have collective builders that take
`const [RelevantOp]::Properties &` arguments, we don't need to serialize
all the attributes that'll be set during an output pattern into a
dictionary attribute. Similarly, we can use the properties struct to get
the attributes instead of needing to go through the big if statement in
getAttrOfType<>().

This also enables us to have declarative rewrite rules that match
non-attribute properties in a future PR.

This commit also adds a basic test for the generated matchers since
there didn't seem to already be one.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications