[all-commits] [llvm/llvm-project] 081668: [flang][OpenMP] Translate OpenMP scopes when compi...

Kareem Ergawy via All-commits all-commits at lists.llvm.org
Mon Mar 10 22:57:52 PDT 2025


  Branch: refs/heads/users/ergawy/try_to_fix_nested_target_conversion_2
  Home:   https://github.com/llvm/llvm-project
  Commit: 08166816bf799bf01565948bed8cfcea0f82b1cb
      https://github.com/llvm/llvm-project/commit/08166816bf799bf01565948bed8cfcea0f82b1cb
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Target/LLVMIR/openmp-target-nesting-in-host-ops.mlir

  Log Message:
  -----------
  [flang][OpenMP] Translate OpenMP scopes when compiling for target device

If a `target` directive is nested in a host OpenMP directive (e.g.
parallel, task, or a worksharing loop), flang currently crashes if the
target directive-related MLIR ops (e.g. `omp.map.bounds` and
`omp.map.info` depends on SSA values defined inside the parent host
OpenMP directives/ops.

This PR tries to solve this problem by treating these parent OpenMP ops
as "SSA scopes". Whenever we are translating for the device, instead of
completely translating host ops, we just tranlate their MLIR ops as pure
SSA values.


  Commit: bf94aebe49e292d845854115b6c53fe3c61289ac
      https://github.com/llvm/llvm-project/commit/bf94aebe49e292d845854115b6c53fe3c61289ac
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  handle some review comments


Compare: https://github.com/llvm/llvm-project/compare/bffc2aa5eceb...bf94aebe49e2

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list