[all-commits] [llvm/llvm-project] 1d1b20: [lldb] Avoid force loading symbol files in statist...

[David Peixotto via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d1b20a19ecf51741f2946976ec5f44a0ed53710
      https://github.com/llvm/llvm-project/commit/1d1b20a19ecf51741f2946976ec5f44a0ed53710
  Author: David Peixotto <peix at meta.com>
  Date:   2025-03-10 (Mon, 10 Mar 2025)

  Changed paths:
    M lldb/include/lldb/Core/Module.h
    M lldb/source/Core/Module.cpp
    M lldb/source/Target/Statistics.cpp
    A lldb/test/Shell/Commands/command-statistics-dump.test
    M lldb/unittests/Symbol/SymtabTest.cpp

  Log Message:
  -----------
  [lldb] Avoid force loading symbol files in statistics collection (#129593)

This commit modifies the `DebuggerStats::ReportStatistics`
implementation to avoid loading symbol files for unloaded symbols. We
collect stats on debugger shutdown and without this change it can cause
the debugger to hang for a long while on shutdown if they symbols were
not previously loaded (e.g. `settings set target.preload-symbols
false`).

The implementation is done by adding an optional parameter to
`Module::GetSymtab` to control if the corresponding symbol file will be
loaded in the same way that can control it for `Module::GetSymbolFile`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications