[all-commits] [llvm/llvm-project] 3db668: [mlir][SparseTensor][NFC] Migrate to OpAsmAttrInte...

Hongren Zheng via All-commits all-commits at lists.llvm.org
Mon Mar 10 09:49:43 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3db668e0bb53958a0b6dacc11751788e3d523a86
      https://github.com/llvm/llvm-project/commit/3db668e0bb53958a0b6dacc11751788e3d523a86
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td
    M mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

  Log Message:
  -----------
  [mlir][SparseTensor][NFC] Migrate to OpAsmAttrInterface for ASM alias generation (#130483)

After the introduction of `OpAsmAttrInterface`, it is favorable to
migrate code using `OpAsmDialectInterface` for ASM alias generation,
which lives in `Dialect.cpp`, to use `OpAsmAttrInterface`, which lives
in `Attrs.td`. In this way, attribute behavior is placed near its
tablegen definition and people won't need to go through other files to
know what other (unexpected) hooks comes into play.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list