[all-commits] [llvm/llvm-project] 8a43bc: [MLIR][LLVMIR] Import: fix llvm.call attribute inh...

[Bruno Cardoso Lopes via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a43bc2c0989864f2635b4f79bb2d453a15cfd9a
      https://github.com/llvm/llvm-project/commit/8a43bc2c0989864f2635b4f79bb2d453a15cfd9a
  Author: Bruno Cardoso Lopes <bruno.cardoso at gmail.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ModuleImport.cpp
    M mlir/test/Target/LLVMIR/Import/call-argument-attributes.ll

  Log Message:
  -----------
  [MLIR][LLVMIR] Import: fix llvm.call attribute inheritance (#130221)

`inst->getFnAttr(Kind)` fallbacks to check if the parent has an
attribute, which breaks roundtriping the LLVM IR. This change actually
checks only in the call attribute list (no fallback to parent queries).

It's possible to argue that this small optimization isn't harmful, but
seems too early if it's breaking roundtrip behavior.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications