[all-commits] [llvm/llvm-project] ca1833: [mlir][OpenMP] cast address space of private varia...

[Tom Eccles via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ca1833b91e45595a3728e90b3714566588c8abae
      https://github.com/llvm/llvm-project/commit/ca1833b91e45595a3728e90b3714566588c8abae
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Target/LLVMIR/omptarget-private-llvm.mlir

  Log Message:
  -----------
  [mlir][OpenMP] cast address space of private variables (#130301)

Fixes #130159

The problem is that the alloca created for the private variable uses the
default alloca address space in that module, but the function the
pointer is being passed to expects a different address space, leading to
a type missmatch in the function argument.

I know nothing about how AMDGPU is supposed to work. I based this
solution on code from createDeviceArgumentAccessor(). Please could
somebody from AMD confirm this solution is appropriate.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications