[all-commits] [llvm/llvm-project] ce9e1d: Modify the localCache API to require an explicit c...

[anjenner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ce9e1d3c15ed6290f1cb07b482939976fa8115cd
      https://github.com/llvm/llvm-project/commit/ce9e1d3c15ed6290f1cb07b482939976fa8115cd
  Author: anjenner <161845516+anjenner at users.noreply.github.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M lldb/source/Core/DataFileCache.cpp
    M llvm/include/llvm/Support/Caching.h
    M llvm/lib/CGData/CodeGenData.cpp
    M llvm/lib/Debuginfod/Debuginfod.cpp
    M llvm/lib/LTO/LTOBackend.cpp
    M llvm/lib/Support/Caching.cpp
    M llvm/tools/gold/gold-plugin.cpp
    M llvm/tools/llvm-lto2/llvm-lto2.cpp
    M llvm/unittests/Support/CMakeLists.txt
    A llvm/unittests/Support/Caching.cpp

  Log Message:
  -----------
  Modify the localCache API to require an explicit commit on CachedFile… (#115331)

…Stream.

CachedFileStream has previously performed the commit step in its
destructor, but this means its only recourse for error handling is
report_fatal_error. Modify this to add an explicit commit() method, and
call this in the appropriate places with appropriate error handling for
the location.

Currently the destructor of CacheStream gives an assert failure in Debug
builds if commit() was not called. This will help track down any
remaining uses of the API that assume the old destructior behaviour. In
Release builds we fall back to the previous behaviour and call
report_fatal_error if the commit fails.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications