[all-commits] [llvm/llvm-project] 81168e: [clang][dataflow] Add test for crash repro and cle...

[Jan Voung via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 81168e2dc1c2069178b1acd5e302be99d7fb0e45
      https://github.com/llvm/llvm-project/commit/81168e2dc1c2069178b1acd5e302be99d7fb0e45
  Author: Jan Voung <jvoung at google.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp
    M clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Add test for crash repro and clean up const accessor handling (#129930)

Add test for https://github.com/llvm/llvm-project/issues/125589

The crash is actually incidentally fixed by
https://github.com/llvm/llvm-project/pull/128437 since it added a branch
for the reference case and would no longer fall through when the return
type is a reference to a pointer.

Clean up a bit as well:
- make the fallback for early returns more consistent (check if
  returning optional and call transfer function for that case)
- check RecordLoc == nullptr in one place
- clean up extra spaces in test
- clean up parameterization in test of `std::` vs `$ns::$`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications