[all-commits] [llvm/llvm-project] dc69ea: [llvm-ar] Fix darwin-related tests' XFAIL annotati...

[Lucas Duarte Prates via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc69eae1c47a0545ae8c3129e44a8fa662612d7c
      https://github.com/llvm/llvm-project/commit/dc69eae1c47a0545ae8c3129e44a8fa662612d7c
  Author: Lucas Duarte Prates <lucas.prates at arm.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M llvm/test/tools/llvm-ar/extract.test
    M llvm/test/tools/llvm-ar/print.test

  Log Message:
  -----------
  [llvm-ar] Fix darwin-related tests' XFAIL annotation (#130144)

The tests updated by this commit are expected to fail when targetting a
darwin platform. As they rely on target detection based on the host,
this is currently checked by using the `XFAIL: system-darwin`
annotation.

This approach becomes a problem when trying to run such tests on a
cross-compiling build of clang on a darwin platform. When no darwin
targets are included in the build, the XFAIL will still apply even
though the target used is not related to the darwin platform, and the
tests will unexpectedly pass.

To fix this issue, this patch updates the condition used by the tests'
XFAIL annotation to `target={{.*}}-darwin{{.*}}`, ensuring they only are
xfailed when the relevant target is used.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications