[all-commits] [llvm/llvm-project] cec36e: Revert "Add LDFLAGS to fix bot failure"

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cec36e279cb871dd011e105e0c9d3edccd0dcad9
      https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2025-03-06 (Thu, 06 Mar 2025)

  Changed paths:
    M lldb/test/API/macosx/no-nlist-memory-module/Makefile

  Log Message:
  -----------
  Revert "Add LDFLAGS to fix bot failure"

This reverts commit 00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977.


  Commit: 82af9888dbbcd248ec4d41968c53135e12e13454
      https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2025-03-06 (Thu, 06 Mar 2025)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
    R lldb/test/API/macosx/no-nlist-memory-module/Makefile
    R lldb/test/API/macosx/no-nlist-memory-module/TestNoNlistsDylib.py
    R lldb/test/API/macosx/no-nlist-memory-module/has-nlists.c
    R lldb/test/API/macosx/no-nlist-memory-module/main.c
    R lldb/test/API/macosx/no-nlist-memory-module/no-nlist-sect.s
    R lldb/test/API/macosx/no-nlist-memory-module/no-nlists.c

  Log Message:
  -----------
  Revert "[lldb][Mach-O] Don't read symbol table of specially marked binary (#129967)"

This reverts commit 397696bb3d26c1298bf265e4907b0b6416ad59c9.

This breaks the macOS CI bots, I need to use $LDFLAGS in the $LD
invocation when building the dylib to get the dylibs to build on
the CI bots.  But I've added "-lno-nlists -lhas-nlists" to the LDFLAGS
for the main binary in the same directory, so using LDFLAGS will
result in a compile error for the dylibs.  I'll need to build the
dylibs in a subdir with a different Makefile, will reland with that
change in a bit.


Compare: https://github.com/llvm/llvm-project/compare/4a0212b9fcaa...82af9888dbbc

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications