[all-commits] [llvm/llvm-project] 6d89c0: [VPlan] Remove dead AnyOf reduction case in VPRedu...

Luke Lau via All-commits all-commits at lists.llvm.org
Thu Mar 6 09:06:15 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6d89c042e3f28c1c5b8fd1ac5512df7020c9739b
      https://github.com/llvm/llvm-project/commit/6d89c042e3f28c1c5b8fd1ac5512df7020c9739b
  Author: Luke Lau <luke at igalia.com>
  Date:   2025-03-07 (Fri, 07 Mar 2025)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

  Log Message:
  -----------
  [VPlan] Remove dead AnyOf reduction case in VPReductionRecipe. NFCI (#130048)

>From what I understand, we only create VPReductionRecipes for in-loop
reductions, and we don't currently support in-loop AnyOf reductions.

We only create VPReductionRecipes in the !PhiR->isInLoop() section of
adjustRecipesForReductions, and this comment from the initial patch
seems to confirm this
https://reviews.llvm.org/D108136#anchor-inline-1038338, so I think we
can remove this check in the condition logic.

I checked compiling SPEC 2017 with -prefer-inloop-predicates and the
added assertion doesn't trigger.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list