[all-commits] [llvm/llvm-project] c72ebe: ADT: Switch to a raw pointer for DoubleAPFloat::Fl...

Peter Collingbourne via All-commits all-commits at lists.llvm.org
Wed Mar 5 21:15:29 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c72ebeeb7f1cebb481243cce3a5b18f548a9d930
      https://github.com/llvm/llvm-project/commit/c72ebeeb7f1cebb481243cce3a5b18f548a9d930
  Author: Peter Collingbourne <pcc at google.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M llvm/include/llvm/ADT/APFloat.h
    M llvm/lib/Support/APFloat.cpp

  Log Message:
  -----------
  ADT: Switch to a raw pointer for DoubleAPFloat::Floats.

In order for the union APFloat::Storage to permit access to the
semantics field when another union member is stored there, all members
of Storage must be standard layout. This is not necessarily the case
for DoubleAPFloat which may be non-standard layout because there is no
requirement that its std::unique_ptr member is standard layout. Fix this
by converting Floats to a raw pointer.

Reviewers: arsenm

Reviewed By: arsenm

Pull Request: https://github.com/llvm/llvm-project/pull/129981



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list