[all-commits] [llvm/llvm-project] 4b454a: Convert unreachable return statement into llvm_unr...

Shafik Yaghmour via All-commits all-commits at lists.llvm.org
Wed Mar 5 17:00:05 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b454afc45cdd69ad7d8d6bdba785b00bda7808c
      https://github.com/llvm/llvm-project/commit/4b454afc45cdd69ad7d8d6bdba785b00bda7808c
  Author: Shafik Yaghmour <shafik.yaghmour at intel.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  Convert unreachable return statement into llvm_unreachable (#129627)

Static analysis flags the final return statement in `ReadExtensionBlock`
as unreachable and indeed it is since there is no way to exit the
`while(true)` loop besides a *return statement*.

So I am converting it into a `llvm_unreachable` to explicitly document
this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list