[all-commits] [llvm/llvm-project] 878a64: [lldb] Upgrade CompilerType::GetBitSize to return ...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 878a64f94a264ea4b564d6063614ddb0b5da3f6c
      https://github.com/llvm/llvm-project/commit/878a64f94a264ea4b564d6063614ddb0b5da3f6c
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M lldb/include/lldb/Expression/ExpressionVariable.h
    M lldb/include/lldb/Symbol/CompilerType.h
    M lldb/include/lldb/Symbol/Type.h
    M lldb/include/lldb/Symbol/TypeSystem.h
    M lldb/include/lldb/Target/StackFrameRecognizer.h
    M lldb/include/lldb/ValueObject/ValueObject.h
    M lldb/include/lldb/ValueObject/ValueObjectCast.h
    M lldb/include/lldb/ValueObject/ValueObjectChild.h
    M lldb/include/lldb/ValueObject/ValueObjectConstResult.h
    M lldb/include/lldb/ValueObject/ValueObjectDynamicValue.h
    M lldb/include/lldb/ValueObject/ValueObjectMemory.h
    M lldb/include/lldb/ValueObject/ValueObjectRegister.h
    M lldb/include/lldb/ValueObject/ValueObjectSyntheticFilter.h
    M lldb/include/lldb/ValueObject/ValueObjectVTable.h
    M lldb/include/lldb/ValueObject/ValueObjectVariable.h
    M lldb/source/API/SBType.cpp
    M lldb/source/API/SBValue.cpp
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Core/Value.cpp
    M lldb/source/DataFormatters/TypeFormat.cpp
    M lldb/source/DataFormatters/VectorType.cpp
    M lldb/source/Expression/ExpressionVariable.cpp
    M lldb/source/Expression/Materializer.cpp
    M lldb/source/Host/macosx/objcxx/Host.mm
    M lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp
    M lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp
    M lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp
    M lldb/source/Plugins/ABI/ARM/ABISysV_arm.cpp
    M lldb/source/Plugins/ABI/LoongArch/ABISysV_loongarch.cpp
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp
    M lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp
    M lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp
    M lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp
    M lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp
    M lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.cpp
    M lldb/source/Plugins/ABI/X86/ABISysV_i386.cpp
    M lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp
    M lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp
    M lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp
    M lldb/source/Plugins/RegisterTypeBuilder/RegisterTypeBuilderClang.cpp
    M lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
    M lldb/source/Symbol/CompilerType.cpp
    M lldb/source/Symbol/Type.cpp
    M lldb/source/Target/StackFrame.cpp
    M lldb/source/Target/Thread.cpp
    M lldb/source/ValueObject/ValueObject.cpp
    M lldb/source/ValueObject/ValueObjectCast.cpp
    M lldb/source/ValueObject/ValueObjectConstResult.cpp
    M lldb/source/ValueObject/ValueObjectDynamicValue.cpp
    M lldb/source/ValueObject/ValueObjectMemory.cpp
    M lldb/source/ValueObject/ValueObjectRegister.cpp
    M lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
    M lldb/source/ValueObject/ValueObjectVTable.cpp
    M lldb/source/ValueObject/ValueObjectVariable.cpp
    M lldb/test/Shell/SymbolFile/DWARF/x86/class-type-nullptr-deref.s
    M lldb/test/Shell/SymbolFile/DWARF/x86/debug-types-signature-loop.s
    M lldb/unittests/Platform/PlatformSiginfoTest.cpp

  Log Message:
  -----------
  [lldb] Upgrade CompilerType::GetBitSize to return llvm::Expected  (#129601)

This patch pushes the error handling boundary for the GetBitSize()
methods from Runtime into the Type and CompilerType APIs. This makes it
easier to diagnose problems thanks to more meaningful error messages
being available. GetBitSize() is often the first thing LLDB asks about a
type, so this method is particularly important for a better user
experience.

rdar://145667239



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications