[all-commits] [llvm/llvm-project] c62373: clang: Do not implicitly addrspacecast in EmitAggE...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/clang/no-implicit-addrspacecast-EmitAggExprToLValue
  Home:   https://github.com/llvm/llvm-project
  Commit: c62373c846263048b7c21abd239d3323af1aca58
      https://github.com/llvm/llvm-project/commit/c62373c846263048b7c21abd239d3323af1aca58
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M clang/lib/CodeGen/CGExprAgg.cpp
    M clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl

  Log Message:
  -----------
  clang: Do not implicitly addrspacecast in EmitAggExprToLValue

This fixes breaking the ABI for calls to the kernel enqueue
implementation functions in OpenCL. The ABI passes these by stack
byref or byval, but this was incorrectly casting the stack slot
and passing to the use function.

I think nearly all uses of CreateMemTemp should not be inserting
this cast, but that will require a larger change with many more test
updates.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications