[all-commits] [llvm/llvm-project] 088e3e: [mlir][ODS] Switch declarative rewrite rules to pr...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/users/krzysz00/declaritve-rewrite-with-properties
  Home:   https://github.com/llvm/llvm-project
  Commit: 088e3e73785e2a8880f0e0cb063d932cf0caab2b
      https://github.com/llvm/llvm-project/commit/088e3e73785e2a8880f0e0cb063d932cf0caab2b
  Author: Krzysztof Drewniak <krzysdrewniak at gmail.com>
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
    A mlir/test/mlir-tblgen/rewriter-attributes-properties.td
    M mlir/tools/mlir-tblgen/RewriterGen.cpp

  Log Message:
  -----------
  [mlir][ODS] Switch declarative rewrite rules to properties structs

Now that we have collective builders that take
`const [RelevantOp]::Properties &` arguments, we don't need to serialize
all the attributes that'll be set during an output pattern into a dictionary
attribute. Similarly, we can use the properties struct to get the attributes
instead of needing to go through the big if statement in getAttrOfType<>().

This also enables us to have declarative rewrite rules that match non-attribute
properties in a future PR.

This commit also adds a basic test for the generated matchers since there
didn't seem to already be one.


  Commit: 1c8f3ebbd0c205db47a74eeab208ed07c0fff5ff
      https://github.com/llvm/llvm-project/commit/1c8f3ebbd0c205db47a74eeab208ed07c0fff5ff
  Author: Krzysztof Drewniak <krzysdrewniak at gmail.com>
  Date:   2025-03-04 (Tue, 04 Mar 2025)

  Changed paths:
    M mlir/test/mlir-tblgen/rewriter-attributes-properties.td

  Log Message:
  -----------
  Test fails on Windows, try to loosen it up


Compare: https://github.com/llvm/llvm-project/compare/d059f7317131...1c8f3ebbd0c2

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications