[all-commits] [llvm/llvm-project] 87006a: [clang] Fix CodeComplete crash involving CWG1432

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/GH125500
  Home:   https://github.com/llvm/llvm-project
  Commit: 87006a41bdb172363935f1e0bb006b9b7e64fb30
      https://github.com/llvm/llvm-project/commit/87006a41bdb172363935f1e0bb006b9b7e64fb30
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Sema/Overload.h
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/SemaCodeComplete.cpp
    M clang/lib/Sema/SemaOverload.cpp
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/test/CXX/drs/cwg14xx.cpp
    A clang/test/CodeCompletion/GH125500.cpp

  Log Message:
  -----------
  [clang] Fix CodeComplete crash involving CWG1432

This skips the provisional resolution of CWG1432 just when ordering the
candidates for function call code completion, as otherwise this breaks some
assumptions the implementation makes about how closely related
the candidates are.

As a drive-by, deduplicate the implementation with the one used for
class template partial ordering, and strenghten an assertion which
was previosuly dependent on the order of candidates.

Also add a test for the fix for CWG1432 when partial ordering function
templates, which was otherwise untested.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications