[all-commits] [llvm/llvm-project] b697bf: [Exegesis][RISCV] Skip some of the tests under exp...

[Min-Yih Hsu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b697bf3c0176e0f9c2f1ab5d39c797469f9037bd
      https://github.com/llvm/llvm-project/commit/b697bf3c0176e0f9c2f1ab5d39c797469f9037bd
  Author: Min Hsu <min.hsu at sifive.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/RISCV/rvv/explicit-sew.test
    M llvm/test/tools/llvm-exegesis/RISCV/rvv/skip-rm.test
    M llvm/test/tools/llvm-exegesis/RISCV/rvv/valid-sew-zvk.test
    M llvm/test/tools/llvm-exegesis/RISCV/rvv/valid-sew.test

  Log Message:
  -----------
  [Exegesis][RISCV] Skip some of the tests under expensive checks

Under expensive checks, some of the tests will fail to pass the
MachineVerifier. It's because right after a snippet is generated, its VL
operand (if it's a register) is assigned a physical register. While
we'll replace it with virtual register in RISCVExegesisPreprocessing,
it's technically violating RISCVInstrInfo's validation rule.
Under normal circumstances, this won't trigger a MachineVerifier failure
because the codegen pipeline doesn't validate the code until the very
end -- which is not the case under EXPENSIVE_CHECKS where
MachineVerifierPass is sprinkled here and there.

This is really caused by the fact that RISCV exegesis has an odd
"codegen" Pass pipeline. And I don't have a good solution yet, so I'm
surpressing these tests under EXPENSIVE_CHECKS.


  Commit: b2cc28cab113554aa63b9097f23796d59175d28f
      https://github.com/llvm/llvm-project/commit/b2cc28cab113554aa63b9097f23796d59175d28f
  Author: Min Hsu <min.hsu at sifive.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/RISCV/rvv/reduction.test

  Log Message:
  -----------
  [Exegesis][RISCV] Only check if vd and vs2 are alias in rvv/reduction.test

This test was designed to check if we alias between vd and vs2. While we
make sure there is no alias relationship between vd and vs1 in the
snippet generator, there is nothing preventing the randomizer to assign
the same register between vs1 and vs2. Which makes this test pretty
unstable.
However, we really only care if vd and vs2 are alias, so instead of
going an extra mile to check whether vd and vs1 are NOT alias, which is
actually irrelevant, we should just focusing on checking if vd and vs2
are alias.


Compare: https://github.com/llvm/llvm-project/compare/ae84717d11bf...b2cc28cab113

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications