[all-commits] [llvm/llvm-project] f363cf: [mlir][tosa][tosa-to-linalg] Ignore Int NaN Mode (...

[Jack Frankland via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f363cfaa74cd209ff972695787d084c6b77b0756
      https://github.com/llvm/llvm-project/commit/f363cfaa74cd209ff972695787d084c6b77b0756
  Author: Jack Frankland <jack.frankland at arm.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
    M mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

  Log Message:
  -----------
  [mlir][tosa][tosa-to-linalg] Ignore Int NaN Mode (#129041)

For non floating point operations NaN propagation mode has no meaning
and can be safely ignored. For non integer types skip the compare and
select materialization for NaN propagation even in "IGNORE" mode. This
fixes a bug where an unchecked `cast<FloatType>()` was called in the
"IGNORE" case even when the operation is acting on integers.

Update the lit tests for the NaN propagation lowering to check that the
propagation logic is not materialized in the case of a non floating
point type e.g. i8.

Signed-off-by: Jack Frankland <jack.frankland at arm.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications