[all-commits] [llvm/llvm-project] 15c49b: [Coroutines] [CodeGen] Don't change AST in CodeGen...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 15c49b9db3f60bdbd320271d5e97f118c00b95dd
      https://github.com/llvm/llvm-project/commit/15c49b9db3f60bdbd320271d5e97f118c00b95dd
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M clang/lib/CodeGen/CGCoroutine.cpp
    M clang/unittests/Frontend/CMakeLists.txt
    A clang/unittests/Frontend/NoAlterCodeGenActionTest.cpp

  Log Message:
  -----------
  [Coroutines] [CodeGen] Don't change AST in CodeGen/Coroutines

The root source of other odd bugs.

We performed a hack in CodeGen/Coroutines. But we didn't recognize that
the CodeGen is a consumer of AST. The CodeGen shouldn't change AST in
any ways. It'll break the assumption about the ASTConsumer in Clang's
framework, which may break any other clang-based tools which depends on
multiple consumers to work together.

The fix here is simple. But I am not super happy about the test. It is
too specific and verbose. We can remove this if we can get the signature
of the AST in ASTContext.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications