[all-commits] [llvm/llvm-project] f79342: [AMDGPU] Use 32-bit index for SWMMAC builtins

Shilei Tian via All-commits all-commits at lists.llvm.org
Thu Feb 27 10:52:00 PST 2025


  Branch: refs/heads/users/shiltian/swmmac-index-32-bit
  Home:   https://github.com/llvm/llvm-project
  Commit: f79342a4b56bbce49f29a934176dd41425ded066
      https://github.com/llvm/llvm-project/commit/f79342a4b56bbce49f29a934176dd41425ded066
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-02-27 (Thu, 27 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/BuiltinsAMDGPU.def
    M clang/test/CodeGenOpenCL/builtins-amdgcn-swmmac-w32.cl
    M clang/test/CodeGenOpenCL/builtins-amdgcn-swmmac-w64.cl
    M cross-project-tests/amdgpu/builtins-amdgcn-swmmac-w32.cl

  Log Message:
  -----------
  [AMDGPU] Use 32-bit index for SWMMAC builtins

Currently, the index of SWMMAC builtins is of type `short`, likely based on the
assumption that K can only be up to 32, meaning there are only 16 non-zero
elements. However, this is not future-proof. This patch updates all of them to
`int`.

The intrinsics themselves don't need to be updated since they accept any integer
type, and in the backend, they are already extended to 32-bit. Additionally, the
tests already use various kinds of integers.

Partially fixes SWDEV-518183.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list