[all-commits] [llvm/llvm-project] 7ffeab: [LLD][ELF] Generically report "address assignment ...

[Daniel Thornburgh via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ffeab3121c984cc00f79b0a78f372a4f7526e3b
      https://github.com/llvm/llvm-project/commit/7ffeab3121c984cc00f79b0a78f372a4f7526e3b
  Author: Daniel Thornburgh <dthorn at google.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M lld/ELF/Writer.cpp
    M lld/test/ELF/linkerscript/symbol-assign-many-passes2.test

  Log Message:
  -----------
  [LLD][ELF] Generically report "address assignment did not converge" (#128774)

There are considerable number of changes done in the address assignment
fixed point loop, and errors in any of them could cause address
assignment not to converge. However, this is reported to the user as
either "thunk creation not converged" or "relaxation not converged".

We saw a confused bug about this in the wild when spilling failed to
converge. (I'm working on a fix for that.)

We may eventually want a complete reason system when reporting address
assignment taking too many passes, but in the interim it seems prudent
to generalize the error message to "address assignment did not
converge".



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications