[all-commits] [llvm/llvm-project] a00586: [clang-tidy]improve performance-unnecessary-value-...

[Congcong Cai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a00586171cdf835148c66704a877740a9f742a3a
      https://github.com/llvm/llvm-project/commit/a00586171cdf835148c66704a877740a9f742a3a
  Author: Congcong Cai <congcongcai0907 at 163.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-value-param.rst
    M clang-tools-extra/test/clang-tidy/checkers/performance/unnecessary-value-param.cpp

  Log Message:
  -----------
  [clang-tidy]improve performance-unnecessary-value-param performance (#128383)

Tolerate fix-it breaking compilation when functions is used as pointers.
`isReferencedOutsideOfCallExpr` will visit the whole translate unit for
each matched function decls. It will waste lots of cpu time in some big
cpp files.
But the benefits of this validation are limited. Lots of function usage
are out of current translation unit.

After removing this validation step, the check profiling changes from
5.7 to 1.1 in SemaExprCXX.cpp, which is similar to version 18.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications