[all-commits] [llvm/llvm-project] 8dd609: Support: Do not check if a file exists before exec...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Feb 25 22:52:01 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8dd609598e498faa34c7bdb777718d6c6622fa27
      https://github.com/llvm/llvm-project/commit/8dd609598e498faa34c7bdb777718d6c6622fa27
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M llvm/lib/Support/Unix/Program.inc
    M llvm/test/tools/llvm-rc/windres-preproc.test

  Log Message:
  -----------
  Support: Do not check if a file exists before executing (#128821)

Let the actual syscall error if the file doesn't exist. This produces
a more standard "no such file or directory" phrasing of the error
message,
and avoids an extra step.

The same antipattern appears in the windows code, we should probably
fix that one too.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list