[all-commits] [llvm/llvm-project] ad94af: [CIR] React to breaking change to DataLayoutTypeIn...

[David Olsen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ad94af973a76ecaa3e6a85304a4abe8130e88bdb
      https://github.com/llvm/llvm-project/commit/ad94af973a76ecaa3e6a85304a4abe8130e88bdb
  Author: David Olsen <dolsen at nvidia.com>
  Date:   2025-02-25 (Tue, 25 Feb 2025)

  Changed paths:
    M clang/lib/CIR/Dialect/IR/CIRTypes.cpp

  Log Message:
  -----------
  [CIR] React to breaking change to DataLayoutTypeInterface (#128772)

In #128754, `DataLayoutTypeInterface` was changed to give
`getPreferredAlignment` a default implemention. As a result, table-gen
no longer declared `getPreferredAlignment` when defining a class that
contained `[DeclareTypeInterfaceMethods<DataLayoutTypeInterface>]` in
the table-gen definition. That means all of the definitions in
`CIRTypes.cpp`, such as `PointerType::getPreferredAligment`, were
compilation errors.

Delete all the definitions of `getPreferredAlignment`. I verified that
the default implementation does the exact same thing as the explicit
overrides that are being deleted.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications