[all-commits] [llvm/llvm-project] 162eb3: [lldb-dap] Add 'source' references to stack frames...

[John Harrison via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 162eb32e747819683d747de29d7fad99f1279063
      https://github.com/llvm/llvm-project/commit/162eb32e747819683d747de29d7fad99f1279063
  Author: John Harrison <harjohn at google.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
    A lldb/test/API/tools/lldb-dap/source/Makefile
    A lldb/test/API/tools/lldb-dap/source/TestDAP_source.py
    A lldb/test/API/tools/lldb-dap/source/main.c
    M lldb/tools/lldb-dap/Handler/SourceRequestHandler.cpp
    M lldb/tools/lldb-dap/JSONUtils.cpp

  Log Message:
  -----------
  [lldb-dap] Add 'source' references to stack frames without source files. (#128268)

This adds 'source' references to all stack frames. When opening a stack
frame users will see the disassembly of the frame if the source is not
available.

This works around the odd behavior of navigating frames without the
VSCode disassembly view open, which causes 'step' to step in the first
frame with a source instead of the active frame.

This fixes #128260

Old behavior:

https://github.com/user-attachments/assets/3f40582d-ac96-451a-a5ae-498a323bf30e

New behavior:

https://github.com/user-attachments/assets/3a3f9ac6-3e6c-4795-9bb2-1132b3916b6f

---------

Co-authored-by: Jonas Devlieghere <jonas at devlieghere.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications