[all-commits] [llvm/llvm-project] d0e37d: [lldb-dap] Refactor request handlers (NFC) (#128262)

Vitaly Buka via All-commits all-commits at lists.llvm.org
Sun Feb 23 18:32:36 PST 2025


  Branch: refs/heads/users/vitalybuka/spr/sanitizer-support-bb-glibc-extension
  Home:   https://github.com/llvm/llvm-project
  Commit: d0e37d9723314199e08e3bb8a61f9b7e033b1ff4
      https://github.com/llvm/llvm-project/commit/d0e37d9723314199e08e3bb8a61f9b7e033b1ff4
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M lldb/tools/lldb-dap/CMakeLists.txt
    M lldb/tools/lldb-dap/DAP.cpp
    M lldb/tools/lldb-dap/DAP.h
    A lldb/tools/lldb-dap/EventHelper.cpp
    A lldb/tools/lldb-dap/EventHelper.h
    A lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/BreakpointLocationsHandler.cpp
    A lldb/tools/lldb-dap/Handler/CompletionsHandler.cpp
    A lldb/tools/lldb-dap/Handler/ConfigurationDoneRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/ContinueRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/DisconnectRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/EvaluateRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/ExceptionInfoRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/InitializeRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/LaunchRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/RequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/RequestHandler.h
    A lldb/tools/lldb-dap/Handler/RestartRequestHandler.cpp
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb-dap] Refactor request handlers (NFC) (#128262)

Currently, all request handlers are implemented as free functions in
lldb-dap.cpp. That file has grown to over 5000 lines and is starting to
become hard to maintain. This PR moves the request handlers into their
own class (and file), together with their documentation.

This PR migrates about a third of the request handlers and the rest will
be migrated in subsequent commits. I'm merging this in an incomplete
state because almost any lldb-dap change is going to result in merge
conflicts and migrating request handlers one by one is easier to review.


  Commit: 8c917f3ccdefe77c180aebc6de41c6828d7aa548
      https://github.com/llvm/llvm-project/commit/8c917f3ccdefe77c180aebc6de41c6828d7aa548
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/tests/sanitizer_format_interceptor_test.cpp

  Log Message:
  -----------
  [NFC][sanitizer] Add test for length sub-specifier "z" (#128448)


  Commit: 0a40825d155e82a514dcc319f1995fb4f2352c7c
      https://github.com/llvm/llvm-project/commit/0a40825d155e82a514dcc319f1995fb4f2352c7c
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/tests/sanitizer_format_interceptor_test.cpp
    M lldb/tools/lldb-dap/CMakeLists.txt
    M lldb/tools/lldb-dap/DAP.cpp
    M lldb/tools/lldb-dap/DAP.h
    A lldb/tools/lldb-dap/EventHelper.cpp
    A lldb/tools/lldb-dap/EventHelper.h
    A lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/BreakpointLocationsHandler.cpp
    A lldb/tools/lldb-dap/Handler/CompletionsHandler.cpp
    A lldb/tools/lldb-dap/Handler/ConfigurationDoneRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/ContinueRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/DisconnectRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/EvaluateRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/ExceptionInfoRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/InitializeRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/LaunchRequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/RequestHandler.cpp
    A lldb/tools/lldb-dap/Handler/RequestHandler.h
    A lldb/tools/lldb-dap/Handler/RestartRequestHandler.cpp
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  rebase

Created using spr 1.3.4


Compare: https://github.com/llvm/llvm-project/compare/07226507ed49...0a40825d155e

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list