[all-commits] [llvm/llvm-project] 91c0aa: [mlir][tensor][nfc] Clarify comments for `createPa...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91c0aa5c1038ea9f4b1565b2f9894d5e8b10e85a
      https://github.com/llvm/llvm-project/commit/91c0aa5c1038ea9f4b1565b2f9894d5e8b10e85a
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/Tensor/Utils/Utils.h
    M mlir/lib/Dialect/Tensor/Utils/Utils.cpp

  Log Message:
  -----------
  [mlir][tensor][nfc] Clarify comments for `createPadHighOp`

While reviewing this code, I realised that the rationale behind the
assert was not very clear, so I updated the comments to clarify it.

Relaxing the assert (i.e., allowing `resType.getNumDynamicDims() !=
dynOutDims.size()`) would require generating a mapping between
`dynOutDims` and the dynamic dimensions of the output tensor. At the
moment, this additional complexity is unnecessary.

To minimize PR noise, I am submitting this without a review. However,
please ping me if you believe this or similar changes should be reviewed
before merging.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications