[all-commits] [llvm/llvm-project] 236fa5: Revert "[Utils] Consolidate `LockstepReverseIterat...

Florian Hahn via All-commits all-commits at lists.llvm.org
Fri Feb 21 13:02:07 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 236fa506d4f166882b63029915333d9599014644
      https://github.com/llvm/llvm-project/commit/236fa506d4f166882b63029915333d9599014644
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    R llvm/include/llvm/Transforms/Utils/LockstepReverseIterator.h
    M llvm/lib/Transforms/Scalar/GVNSink.cpp
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp

  Log Message:
  -----------
  Revert "[Utils] Consolidate `LockstepReverseIterator` into own header (NFC) (#116657)"

This reverts commit 123dca9b56e1359d8ec7771ea3bd0afd4b1ea6af.

This breaks building on macOS with clang and multiple build bots,
including https://lab.llvm.org/buildbot/#/builders/175/builds/13585

    llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp: In function ‘bool sinkCommonCodeFromPredecessors(llvm::BasicBlock*, llvm::DomTreeUpdater*)’:
    /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2503:3: error: reference to ‘LockstepReverseIterator’ is ambiguous
     2503 |   LockstepReverseIterator<true> LRI(UnconditionalPreds);
          |   ^~~~~~~~~~~~~~~~~~~~~~~



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list