[all-commits] [llvm/llvm-project] 741f92: [MemProf] Minor fixes to dot graph printing (#128217)

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 741f923fac33880d24e9990f0b90c77daa2fb4b6
      https://github.com/llvm/llvm-project/commit/741f923fac33880d24e9990f0b90c77daa2fb4b6
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
    M llvm/test/ThinLTO/X86/memprof-basic.ll
    M llvm/test/ThinLTO/X86/memprof-indirectcall.ll
    M llvm/test/ThinLTO/X86/memprof-inlined.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/basic.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/duplicate-context-ids.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/indirectcall.ll
    M llvm/test/Transforms/MemProfContextDisambiguation/inlined.ll

  Log Message:
  -----------
  [MemProf] Minor fixes to dot graph printing (#128217)

Two misc cleanup/improvements to the dot printing.

Remove a redundant "style=filled" in the Node attributes. No effect on
resulting graph.

Add a "color" attribute to the Edge, with the same color name as
"fillcolor". The latter only fills in the arrowhead, and the former is
what affects the line. This makes the edge colors more visible,
previously it was a black edge with a colored in arrowhead.

For the second change, I added the new Edge color attributes to the
checking in the two "basic.ll" tests, so we get some testing coverage of
the full printing. For the other affected tests I removed the final "]'"
after the fillcolor so it matches up through that attribute and ignores
the rest of the line.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications