[all-commits] [llvm/llvm-project] 45798b: [RISCV] Simplify the debug messages in the disasse...

Craig Topper via All-commits all-commits at lists.llvm.org
Fri Feb 21 09:49:03 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 45798bd4841649c1c41ca48701536f1bc808e1a6
      https://github.com/llvm/llvm-project/commit/45798bd4841649c1c41ca48701536f1bc808e1a6
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp

  Log Message:
  -----------
  [RISCV] Simplify the debug messages in the disassembler. (#128102)

Move the printing of "table" to the macro instantiation.

Don't use string concatenation in the macro. Print DESC as it own
string. This allows the "Trying " and " table:" to only appear in the
binary once instead of being part of every string.

Remove "custom opcode" from the messages, I don't think it provides much
value after mentioning the vendor.

I'm hoping to replace the macros with a table of features, decoder table
pointer, and string that we can iterate over.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list