[all-commits] [llvm/llvm-project] cc675c: [utils] Use stricter SSA regexp for CHECK-SAME. (#...

Slava Zakharin via All-commits all-commits at lists.llvm.org
Thu Feb 20 21:18:33 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc675c635bf0016111050531e75f8082d0ea120b
      https://github.com/llvm/llvm-project/commit/cc675c635bf0016111050531e75f8082d0ea120b
  Author: Slava Zakharin <szakharin at nvidia.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M mlir/utils/generate-test-checks.py

  Log Message:
  -----------
  [utils] Use stricter SSA regexp for CHECK-SAME. (#128083)

When CHECK-SAME checks are split across multiple lines,
the '.*' regexp for the SSA variable name may cause problems, e.g.:
```
// CHECK_LABEL: func.func @whatever(
// CHECK-SAME: %[[VAL_0:.*]]: i32,
// CHECK-SAME: %[[VAL_1:.*]]: i32,
// CHECK-SAME: %[[VAL_2:.*]]: i64)
```

This will not work for `func.func @whatever(%0: i32, %1: i32, %2: i64)`,
because VAL_0 will match to `0: i32, %1`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list