[all-commits] [llvm/llvm-project] 9fa77c: [BOLT][Linker][NFC] Remove lookupSymbol() in favor...

YongKang Zhu via All-commits all-commits at lists.llvm.org
Thu Feb 20 17:14:55 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9fa77c18548a4878cf53a5195f69d15a2d1d567f
      https://github.com/llvm/llvm-project/commit/9fa77c18548a4878cf53a5195f69d15a2d1d567f
  Author: YongKang Zhu <yongzhu at fb.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M bolt/include/bolt/Core/Linker.h
    M bolt/lib/Core/BinaryFunction.cpp
    M bolt/lib/Rewrite/JITLinkLinker.cpp
    M bolt/lib/Rewrite/RewriteInstance.cpp
    M bolt/lib/RuntimeLibs/HugifyRuntimeLibrary.cpp
    M bolt/lib/RuntimeLibs/InstrumentationRuntimeLibrary.cpp

  Log Message:
  -----------
  [BOLT][Linker][NFC] Remove lookupSymbol() in favor of lookupSymbolInfo() (#128070)

Sometimes we need to know the size of a symbol besides its address, so
maybe we can start using the existing `BOLTLinker::lookupSymbolInfo()`
(that returns symbol address and size) and remove
`BOLTLinker::lookupSymbol()` (that only returns symbol address). And for
both we need to check return value as it is wrapped in `std::optional<>`,
which makes the difference even smaller.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list