[all-commits] [llvm/llvm-project] 598133: [libc] Fix scanf cmake for targets without FILE (#...

Michael Jones via All-commits all-commits at lists.llvm.org
Thu Feb 20 13:48:07 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5981335d75412977862003816d67d9b01fcd04b6
      https://github.com/llvm/llvm-project/commit/5981335d75412977862003816d67d9b01fcd04b6
  Author: Michael Jones <michaelrj at google.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M libc/src/stdio/scanf_core/CMakeLists.txt
    M libc/test/src/stdio/scanf_core/CMakeLists.txt

  Log Message:
  -----------
  [libc] Fix scanf cmake for targets without FILE (#128056)

Another followup fix to #121215

The new cmake wouldn't define the readerat all if the target wasn't GPU
or didn't have a definition of FILE. This patch rewrites the cmake to be
more general.

As a followup, I'd like to make `use_system_file` consistent between
/test and /src. Currently in /src it includes the `COMPILE_OPTIONS` and
in /test it does not.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list