[all-commits] [llvm/llvm-project] e26431: [lldb] Fix RangeDataVector::CombineConsecutiveEntr...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e264317b45163f5c3ba7fc5375dcdecd827fce95
      https://github.com/llvm/llvm-project/commit/e264317b45163f5c3ba7fc5375dcdecd827fce95
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M lldb/include/lldb/Utility/RangeMap.h
    M lldb/test/Shell/Commands/command-disassemble.s
    M lldb/unittests/Utility/RangeMapTest.cpp

  Log Message:
  -----------
  [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (#127059)

Function was merging equal data even if they weren't adjecant. This
caused a problem in command-disassemble.s test because the two ranges
describing the function would be merged and "swallow" the function
between them.

This PR copies/adapts the algorithm from
RangeVector::CombineConsecutiveEntries (which does not have the same
problem) and also adds a call to ComputeUpperBounds as moving entries
around invalidates the binary tree. (The lack of this call wasn't
noticed until now either because we were not calling methods which rely
on upper bounds (right now, it's only the ill-named FindEntryIndexes
method), or because we weren't merging anything.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications