[all-commits] [llvm/llvm-project] 9743b9: [libclc] Explicitly qualify private address spaces...

[Fraser Cormack via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9743b99cd1d1775f9f367e5f1c6d40ba09ec523b
      https://github.com/llvm/llvm-project/commit/9743b99cd1d1775f9f367e5f1c6d40ba09ec523b
  Author: Fraser Cormack <fraser at codeplay.com>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M libclc/generic/lib/math/ep_log.cl
    M libclc/generic/lib/math/ep_log.h
    M libclc/generic/lib/math/modf.inc
    M libclc/generic/lib/math/sincos_helpers.cl
    M libclc/generic/lib/math/sincos_helpers.h

  Log Message:
  -----------
  [libclc] Explicitly qualify private address spaces (#127823)

Doing so provides stability when compiling the builtins in a mode in
which unqualified pointers may be interpreted as being in the generic
address space, such as in OpenCL 3.0.

We eventually want to provide 'generic' overloads of the builtins in
libclc so this prepares the ground a little better.

It could be argued that having the internal CLC helper functions be
unqualified is more flexible, in case it's better for a target to have
the pointers in the generic address space. This commits to the private
address space for more stability across different OpenCL environments.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications