[all-commits] [llvm/llvm-project] 8e16e5: [HLSL] Bug fix crash using Array Parameters when D...

Sarah Spall via All-commits all-commits at lists.llvm.org
Tue Feb 18 10:49:48 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e16e5ca23d70b6d21346abfbe292aa7e91dcb2e
      https://github.com/llvm/llvm-project/commit/8e16e5ca23d70b6d21346abfbe292aa7e91dcb2e
  Author: Sarah Spall <sarahspall at microsoft.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M clang/lib/AST/ASTContext.cpp
    M clang/test/AST/HLSL/TypdefArrayParam.hlsl

  Log Message:
  -----------
  [HLSL] Bug fix crash using Array Parameters when De-sugaring is the same as canonicalizing  (#127670)

Fixes this crash: https://hlsl.godbolt.org/z/9aP74s4bP
Which happens because the de-sugared type is the same as the
canonicalized type.
Check if the de-sugared type is canonical before getting the
ArrayParameterType of the canonical type.
Add AST test to ensure crash doesn't happen.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list