[all-commits] [llvm/llvm-project] fc37dc: AMDGPU: More consistently use the fold list instea...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/amdgpu/si-fold-operands-use-fold-list
  Home:   https://github.com/llvm/llvm-project
  Commit: fc37dccf252ad5ce40bbee3fb8f222ee1bc89a4e
      https://github.com/llvm/llvm-project/commit/fc37dccf252ad5ce40bbee3fb8f222ee1bc89a4e
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
    A llvm/test/CodeGen/AMDGPU/si-fold-operands-commute-same-operands-assert.mir

  Log Message:
  -----------
  AMDGPU: More consistently use the fold list instead of direct mutation

There were 2 parallel fold check mechanisms, so consistently use the
fold list. The worklist management here is still not good. Other types
of folds are not using it, and we should probably rewrite the pass to
look more like peephole-opt.

This should be an alternative fix to skipping commute if the operands
are the same (#127562). The new test is still not broken as-is, but
demonstrates failures in a future patch.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications