[all-commits] [llvm/llvm-project] e3cab3: [clang][deps] Ensure DiagnosticConsumer::finish is...

[Ben Langmuir via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e3cab30ab96e1d22bbedff005673ae0c1431c3af
      https://github.com/llvm/llvm-project/commit/e3cab30ab96e1d22bbedff005673ae0c1431c3af
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2025-02-13 (Thu, 13 Feb 2025)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
    M clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp

  Log Message:
  -----------
  [clang][deps] Ensure DiagnosticConsumer::finish is always called (#127110)

When using the clang dependency scanner with an arbitrary
DiagnosticConsumer, it is important that we always call finish().
Previously, if there was an error preventing us from reaching the
scanning action, or if the command line contained no scannable actions
we would fail to finish(), which would break some consumers (e.g.
serialized diag consumer).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications