[all-commits] [llvm/llvm-project] 9388aa: self-review: define an error token to denote lex e...

Finn Plummer via All-commits all-commits at lists.llvm.org
Wed Feb 12 15:22:00 PST 2025


  Branch: refs/heads/users/inbelic/pr-122982
  Home:   https://github.com/llvm/llvm-project
  Commit: 9388aaed4cc3312d0db8a538a6940337e25168e0
      https://github.com/llvm/llvm-project/commit/9388aaed4cc3312d0db8a538a6940337e25168e0
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/HLSLRootSignatureTokenKinds.def
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  self-review: define an error token to denote lex errors during peek

- the current use of invalid is not able to distinguish between a lex
error that has been reported to diagnostics and an invalid token that
should be reported during parsing
- an error token is defined as the default token to denote a lex error
that has been reported and shouldn't be handled by the parsing


  Commit: d60ce4852edc9fd9596a8702deef0a941566a862
      https://github.com/llvm/llvm-project/commit/d60ce4852edc9fd9596a8702deef0a941566a862
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    A llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  [HLSL][RootSignature] Handle an empty root signature

- Define the Parser struct
- Model RootElements as a variant of the different types
- Create a basic test case for unit testing


  Commit: d2301399044ea8fbd6c0681daca38ab029a97815
      https://github.com/llvm/llvm-project/commit/d2301399044ea8fbd6c0681daca38ab029a97815
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for an empty descriptor table


  Commit: 457acaabec4a896d432d983e0645f2ba6fb50d98
      https://github.com/llvm/llvm-project/commit/457acaabec4a896d432d983e0645f2ba6fb50d98
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  add diagnostics to methods


  Commit: 7fba04c0c0bf3248498e1d51d76c67c5e92f84ca
      https://github.com/llvm/llvm-project/commit/7fba04c0c0bf3248498e1d51d76c67c5e92f84ca
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for empty descriptor table clause


  Commit: e7b54bc9c54eab1cbf9d08fd96d741bb12030ce8
      https://github.com/llvm/llvm-project/commit/e7b54bc9c54eab1cbf9d08fd96d741bb12030ce8
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for parsing registers


  Commit: b160219598d95b9fdd407d2cebd6d61c1ad9fc71
      https://github.com/llvm/llvm-project/commit/b160219598d95b9fdd407d2cebd6d61c1ad9fc71
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for optional parameters

- use numDescriptors as an example


  Commit: 5175c32db86f75b9a99daef2db6b29eb172fa3eb
      https://github.com/llvm/llvm-project/commit/5175c32db86f75b9a99daef2db6b29eb172fa3eb
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  add diagnostic for repeated parametr


  Commit: eec1d0ef987f5c62e08bad2e98c2ab78157f1d78
      https://github.com/llvm/llvm-project/commit/eec1d0ef987f5c62e08bad2e98c2ab78157f1d78
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add space optional parameter

- demonstrate can specify in any order


  Commit: f8a554300615cf7ed1dba0154812d3dccbdc5afe
      https://github.com/llvm/llvm-project/commit/f8a554300615cf7ed1dba0154812d3dccbdc5afe
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for custom parameter parsing - DescriptorRangeOffset


  Commit: 847974b624272ef024b0089aff4d6c49293cb636
      https://github.com/llvm/llvm-project/commit/847974b624272ef024b0089aff4d6c49293cb636
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for shader visibility

- introduces the ParseEnum function that will parse any of the ENUM
token definitions


  Commit: 1f752480afe6b08412376c91b5fff669b4e96cd1
      https://github.com/llvm/llvm-project/commit/1f752480afe6b08412376c91b5fff669b4e96cd1
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

  Log Message:
  -----------
  add support for parsing Flag parameters

- use DescriptorRangeFlags to demonstrate valid functionality


  Commit: a9d4d56207c839b0a48941c27f41c13834d39aa6
      https://github.com/llvm/llvm-project/commit/a9d4d56207c839b0a48941c27f41c13834d39aa6
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  add diagnostic for non-zero int literal as flag


  Commit: 1df25676d132fdc69e2f88babb587d4fb57937f3
      https://github.com/llvm/llvm-project/commit/1df25676d132fdc69e2f88babb587d4fb57937f3
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h

  Log Message:
  -----------
  review: doxygen comment updates


  Commit: ccffe1fb54a9eb7c17e5c39d42666ecd42ba547c
      https://github.com/llvm/llvm-project/commit/ccffe1fb54a9eb7c17e5c39d42666ecd42ba547c
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  clang format visit function


Compare: https://github.com/llvm/llvm-project/compare/217cb76bdc68...ccffe1fb54a9

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list