[all-commits] [llvm/llvm-project] ceb00c: [mlir][acc] Clean up TypedValue builders (#126968)

Razvan Lupusoru via All-commits all-commits at lists.llvm.org
Wed Feb 12 14:14:07 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ceb00c07028491506bcf8e334bb12cab7792098f
      https://github.com/llvm/llvm-project/commit/ceb00c07028491506bcf8e334bb12cab7792098f
  Author: Razvan Lupusoru <razvan.lupusoru at gmail.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td

  Log Message:
  -----------
  [mlir][acc] Clean up TypedValue builders (#126968)

When MappableType was introduced alongside PointerLikeType, the data
clause operation builders were duplicated to accept a `TypedValue` of
one of the two type options. However, the underlying builder takes a
`Value` and this difference is not relevant for it. The only difference
is that `varType` is set differently depending on the type.

Having two duplicated builders can lead to clunky building since a
`Value` must always be cast to one of the two options. Thus, simply
clean this up - the verifier already checks that it is a type that
implements one of the two interfaces.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list