[all-commits] [llvm/llvm-project] 92f916: Add a pass to collect dropped var statistics for M...

[Shubham Sandeep Rastogi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 92f916faba13e5cf575f6aef64405b51eaccfe9a
      https://github.com/llvm/llvm-project/commit/92f916faba13e5cf575f6aef64405b51eaccfe9a
  Author: Shubham Sandeep Rastogi <srastogi22 at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    A llvm/include/llvm/CodeGen/DroppedVariableStatsMIR.h
    A llvm/include/llvm/IR/DroppedVariableStats.h
    A llvm/include/llvm/IR/DroppedVariableStatsIR.h
    R llvm/include/llvm/Passes/DroppedVariableStats.h
    R llvm/include/llvm/Passes/DroppedVariableStatsIR.h
    M llvm/include/llvm/Passes/StandardInstrumentations.h
    M llvm/lib/CodeGen/CMakeLists.txt
    A llvm/lib/CodeGen/DroppedVariableStatsMIR.cpp
    M llvm/lib/CodeGen/MachineFunctionPass.cpp
    M llvm/lib/IR/CMakeLists.txt
    A llvm/lib/IR/DroppedVariableStats.cpp
    A llvm/lib/IR/DroppedVariableStatsIR.cpp
    M llvm/lib/Passes/CMakeLists.txt
    R llvm/lib/Passes/DroppedVariableStatsIR.cpp
    M llvm/unittests/CodeGen/CMakeLists.txt
    A llvm/unittests/CodeGen/DroppedVariableStatsMIRTest.cpp

  Log Message:
  -----------
  Add a pass to collect dropped var statistics for MIR (#126686)

This patch attempts to reland
https://github.com/llvm/llvm-project/pull/120780 while addressing the
issues that caused the patch to be reverted.

Namely:

1. The patch had included code from the llvm/Passes directory in the
llvm/CodeGen directory.

2. The patch increased the backend compile time by 2% due to adding a
very expensive include in MachineFunctionPass.h

The patch has been re-structured so that there is no dependency between
the llvm/Passes and llvm/CodeGen directory, by moving the base class,
`class DroppedVariableStats` to the llvm/IR directory.

The expensive include in MachineFunctionPass.h has been changed to
contain forward declarations instead of other header includes which was
pulling a ton of code into MachineFunctionPass.h and should resolve any
issues when it comes to compile time increase.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications