[all-commits] [llvm/llvm-project] 479dcc: [HLSL][RootSignature] Handle an empty root signature
Finn Plummer via All-commits
all-commits at lists.llvm.org
Wed Feb 12 09:38:34 PST 2025
Branch: refs/heads/users/inbelic/pr-122982
Home: https://github.com/llvm/llvm-project
Commit: 479dcca55ea4f494751ad85d023e6efeb6e6c35e
https://github.com/llvm/llvm-project/commit/479dcca55ea4f494751ad85d023e6efeb6e6c35e
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
A llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
[HLSL][RootSignature] Handle an empty root signature
- Define the Parser struct
- Model RootElements as a variant of the different types
- Create a basic test case for unit testing
Commit: 4772ecc671843cf7d885215e47903a73edebccd5
https://github.com/llvm/llvm-project/commit/4772ecc671843cf7d885215e47903a73edebccd5
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for an empty descriptor table
Commit: 17c2618218c9d3893758e7ad07ce2580512a5f26
https://github.com/llvm/llvm-project/commit/17c2618218c9d3893758e7ad07ce2580512a5f26
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Basic/DiagnosticParseKinds.td
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
add diagnostics to methods
Commit: c873b3265d8d4f5c7795bbbf00686166d768b6cc
https://github.com/llvm/llvm-project/commit/c873b3265d8d4f5c7795bbbf00686166d768b6cc
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for empty descriptor table clause
Commit: 0305544288edd623c011a3e027f05f0f7d7d1f3a
https://github.com/llvm/llvm-project/commit/0305544288edd623c011a3e027f05f0f7d7d1f3a
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for parsing registers
Commit: 742e62c89f6c255ad9a351348064551c5971baa1
https://github.com/llvm/llvm-project/commit/742e62c89f6c255ad9a351348064551c5971baa1
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for optional parameters
- use numDescriptors as an example
Commit: c8a1e3826aa2e9bc70892f40c906db96f615ca6f
https://github.com/llvm/llvm-project/commit/c8a1e3826aa2e9bc70892f40c906db96f615ca6f
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Basic/DiagnosticParseKinds.td
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
add diagnostic for repeated parametr
Commit: 75271b57054125966b5571b87c3b801d77fd1013
https://github.com/llvm/llvm-project/commit/75271b57054125966b5571b87c3b801d77fd1013
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add space optional parameter
- demonstrate can specify in any order
Commit: e8e074a769c37d2ab06db6e46b5409a9d2f9a679
https://github.com/llvm/llvm-project/commit/e8e074a769c37d2ab06db6e46b5409a9d2f9a679
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for custom parameter parsing - DescriptorRangeOffset
Commit: 4ed3abf4c99d61211f77f01fea416da05cab4b23
https://github.com/llvm/llvm-project/commit/4ed3abf4c99d61211f77f01fea416da05cab4b23
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for shader visibility
- introduces the ParseEnum function that will parse any of the ENUM
token definitions
Commit: 3c928d5feaa085e74b3b0e68e5f2684e3d035a5f
https://github.com/llvm/llvm-project/commit/3c928d5feaa085e74b3b0e68e5f2684e3d035a5f
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
add support for parsing Flag parameters
- use DescriptorRangeFlags to demonstrate valid functionality
Commit: d037590f585f1ac5bdd40d015b80fe781360d423
https://github.com/llvm/llvm-project/commit/d037590f585f1ac5bdd40d015b80fe781360d423
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Basic/DiagnosticParseKinds.td
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
add diagnostic for non-zero int literal as flag
Commit: 9ee3e654c6784a8a565f051200e31d2cf3d2175d
https://github.com/llvm/llvm-project/commit/9ee3e654c6784a8a565f051200e31d2cf3d2175d
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/lib/Parse/ParseHLSLRootSignature.cpp
Log Message:
-----------
visit clang-format
Commit: e030faf81b2b0558db8836bd1f722794cc629bac
https://github.com/llvm/llvm-project/commit/e030faf81b2b0558db8836bd1f722794cc629bac
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/lib/Parse/ParseHLSLRootSignature.cpp
Log Message:
-----------
small missed update from restructuring
Commit: d0b815b2268cf6f6792bf90b3d58e53572684dff
https://github.com/llvm/llvm-project/commit/d0b815b2268cf6f6792bf90b3d58e53572684dff
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
Log Message:
-----------
review: update namespace
- reduce namespace for brevity
- remove introducing rs namespace and use new namespace instead
Commit: 8a464ecbb0d0128a91daaa225a6a6e2ccb575214
https://github.com/llvm/llvm-project/commit/8a464ecbb0d0128a91daaa225a6a6e2ccb575214
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/lib/Parse/ParseHLSLRootSignature.cpp
Log Message:
-----------
review: remove unneeded returns after llvm_unreachable
Commit: afabdda333daffd63b96ca4e8dca0fd90b3a4ec5
https://github.com/llvm/llvm-project/commit/afabdda333daffd63b96ca4e8dca0fd90b3a4ec5
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
Log Message:
-----------
review: pass DenseMap by reference
Commit: 99f9afd89c02ec54025a2da0390895fffb50f1c6
https://github.com/llvm/llvm-project/commit/99f9afd89c02ec54025a2da0390895fffb50f1c6
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Parse/ParseHLSLRootSignature.h
Log Message:
-----------
review: adjust comments for doxygen
Commit: 99b569116bddb2929689130eb58c903a6db58b9a
https://github.com/llvm/llvm-project/commit/99b569116bddb2929689130eb58c903a6db58b9a
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/include/clang/Basic/DiagnosticParseKinds.td
M clang/include/clang/Parse/ParseHLSLRootSignature.h
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
review: rebase onto lexer api changes
- we have changed the api of the lexer to avoid pre-allocating all the
tokens and instead to have the parser only invoke
ConsumeToken/PeekNextToken when needed
- the end of stream diagnostic is also moved to the lexer
Commit: 5ca354764cf66b67e1379cfc7bd48865b0497b20
https://github.com/llvm/llvm-project/commit/5ca354764cf66b67e1379cfc7bd48865b0497b20
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
lexer review: let end_of_stream error be unexpected token instead
Commit: c6c9a12bc7a23f2a18352625c8e5ae9b637d8dad
https://github.com/llvm/llvm-project/commit/c6c9a12bc7a23f2a18352625c8e5ae9b637d8dad
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
lexer review: let invalid_token error be an unexpected_token error
Commit: 217cb76bdc68cb7493f797d51a41b51d1fc60da8
https://github.com/llvm/llvm-project/commit/217cb76bdc68cb7493f797d51a41b51d1fc60da8
Author: Finn Plummer <canadienfinn at gmail.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M clang/lib/Parse/ParseHLSLRootSignature.cpp
M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
Log Message:
-----------
lexer review: handle parsing of unsigned integers
Compare: https://github.com/llvm/llvm-project/compare/73a1d980682b...217cb76bdc68
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list