[all-commits] [llvm/llvm-project] 8ac979: review: fix some typos

[Finn Plummer via All-commits]

  Branch: refs/heads/users/inbelic/pr-122981
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ac979c5d6dcf3ea6ab5f20975ec2d100375457c
      https://github.com/llvm/llvm-project/commit/8ac979c5d6dcf3ea6ab5f20975ec2d100375457c
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: fix some typos


  Commit: 0c372bfb72e16595e33282d75726f46c1012c3c8
      https://github.com/llvm/llvm-project/commit/0c372bfb72e16595e33282d75726f46c1012c3c8
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: remove unique end_of_stream lexing error

- instead of reporting the unique end_of_stream error, we can instead
pass up an end_of_stream token and let the unexpected diag reporting
handles this in the parser with more context


  Commit: e58c89aeccdf50e5779900122d497f8f14dc3fc5
      https://github.com/llvm/llvm-project/commit/e58c89aeccdf50e5779900122d497f8f14dc3fc5
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: remove unique invalid_token lexing error

- similarily, we can let the unexpected_token diagnostics reporting
handle this error by passing up an invalid token and provide more
context


  Commit: aa7a73d0214e9923c0771caf8ee57830e81cc32b
      https://github.com/llvm/llvm-project/commit/aa7a73d0214e9923c0771caf8ee57830e81cc32b
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/include/clang/Parse/HLSLRootSignatureTokenKinds.def
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: punt parsing of a signed integer to the parser


Compare: https://github.com/llvm/llvm-project/compare/35c15661e708...aa7a73d0214e

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications