[all-commits] [llvm/llvm-project] c2fea0: [clang-linker-wrapper][lit] Fix SPIR-V ELF test wh...

[Nick Sarnie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c2fea0d837c481c2c1f00077778f84de54c0196f
      https://github.com/llvm/llvm-project/commit/c2fea0d837c481c2c1f00077778f84de54c0196f
  Author: Nick Sarnie <nick.sarnie at intel.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/test/CMakeLists.txt
    M clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
    M clang/test/Tooling/lit.local.cfg

  Log Message:
  -----------
  [clang-linker-wrapper][lit] Fix SPIR-V ELF test when spirv-tools feature is available (#126756)

My last change made the test not run when the `spirv-tools` feature is
not available, which is always the case in CI for clang tests, but it
fails if `spirv-tools` is available for the following reasons:
1) We didn't build `spirv-link` as part of the internal `SPIRV-Tools`
build, which is required by the `clang` call in `clang-linker-wrapper`,
I already fixed that
[here](https://github.com/llvm/llvm-project/pull/126319).
2) We didn't depend on the `SPIRV-Tools` CMake targets in clang tests,
so depending on what CMake targets were built before running
`check-clang`, `SPIRV-Tools` might not have been built.
3) We didn't check for `llvm-spirv` being available, which is not part
of `SPIRV-Tools` but is currently required for SPIR-V compilation.

Manually confirmed this works. This test is the bane of my existence.

---------

Signed-off-by: Sarnie, Nick <nick.sarnie at intel.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications