[all-commits] [llvm/llvm-project] 82c645: review: update uses of llvm_unreachable

[Finn Plummer via All-commits]

  Branch: refs/heads/users/inbelic/pr-122981
  Home:   https://github.com/llvm/llvm-project
  Commit: 82c645d4049950bdcfb151b0093708338dd1e714
      https://github.com/llvm/llvm-project/commit/82c645d4049950bdcfb151b0093708338dd1e714
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  review: update uses of llvm_unreachable


  Commit: 1c95e6d852f668b5fbab05a4ebe48526b190a5d5
      https://github.com/llvm/llvm-project/commit/1c95e6d852f668b5fbab05a4ebe48526b190a5d5
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: update target test triple with comment


  Commit: d648f4ccb8c74060e9e6d75b46f54ac0127e4302
      https://github.com/llvm/llvm-project/commit/d648f4ccb8c74060e9e6d75b46f54ac0127e4302
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: dealing with signed positive integer

- the previous implementation would not have thrown an overflow error as
expected. Instead it would have been treated as a negative int
- DXC treats all positively signed ints as an unsigned integer, so for
compatibility, we will be doing the same.
- add better unit tests to demonstrate expected functionality


  Commit: de2f62e26d1c8e1bc9c1fd2aebe15acfc46147ec
      https://github.com/llvm/llvm-project/commit/de2f62e26d1c8e1bc9c1fd2aebe15acfc46147ec
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: update diagnostics message


  Commit: f557d5a922f2d79103c96abbb15c880d91fbf038
      https://github.com/llvm/llvm-project/commit/f557d5a922f2d79103c96abbb15c880d91fbf038
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  review: update linked todo


  Commit: de364d896b24ea782b42e97fe76f71ebdbeaaa9e
      https://github.com/llvm/llvm-project/commit/de364d896b24ea782b42e97fe76f71ebdbeaaa9e
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/include/clang/Parse/HLSLRootSignatureTokenKinds.def
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review: remove api for pre-allocating tokens

- we want to prevent the pre-allocation of all the tokens and rather let
the parser allocate the tokens as it goes along
- this allows for a quicker cycle to the user if there is a parsing
error as we don't need to lex all of the tokens before trying to parse

- as such, this change provides a new api for interacting with the lexer
through ConsumeToken and PeekNextToken as opposed to generated the
entire list of lexed tokens


  Commit: 35c15661e7082ea090578547e2de4c29cd0ba37a
      https://github.com/llvm/llvm-project/commit/35c15661e7082ea090578547e2de4c29cd0ba37a
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  clang format


Compare: https://github.com/llvm/llvm-project/compare/dc784ffa0da9...35c15661e708

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications